Skip to content

🎨 Palette: Add ARIA state to custom dropdown toggles - #243

Open
endlessblink wants to merge 2 commits into
masterfrom
palette-ux-dropdown-aria-4005737871893870453
Open

🎨 Palette: Add ARIA state to custom dropdown toggles#243
endlessblink wants to merge 2 commits into
masterfrom
palette-ux-dropdown-aria-4005737871893870453

Conversation

@endlessblink

Copy link
Copy Markdown
Owner

💡 What: Added aria-expanded and aria-haspopup attributes to the trigger buttons for custom dropdown menus in QuickTaskDropdown.vue and CalendarHeader.vue.
🎯 Why: Screen reader users need to know if a button opens a dialog/menu and what its current expanded state is. This allows assistive technologies to announce the dropdown's state correctly.
📸 Before/After: No visual changes.
♿ Accessibility: Improves custom component compatibility with screen readers by adhering to ARIA guidelines for custom popovers.


PR created automatically by Jules for task 4005737871893870453 started by @endlessblink

Added `aria-expanded` and `aria-haspopup` to custom dropdown triggers in Quick Tasks and Calendar View Options. Also resolved a pre-existing Vue lint warning in the Calendar Header.

Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Removed `supabase/setup-cli@v1` from the GitHub Actions workflows and updated scripts/run-e2e.sh to use `npx supabase` in order to resolve rate limits and Node version deprecation issues. Fixed Vue template linting failures across `QuickSortCard.vue`, `BaseInput.vue`, `App.vue`, `AIMemoryHealthDashboard.vue`, and `ChatMessage.vue`.

Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant