🎨 Palette: Add dynamic ARIA interaction states to dropdowns and toggles - #245
Open
endlessblink wants to merge 4 commits into
Open
🎨 Palette: Add dynamic ARIA interaction states to dropdowns and toggles#245endlessblink wants to merge 4 commits into
endlessblink wants to merge 4 commits into
Conversation
Added `:aria-expanded` and `:aria-pressed` to interactive components to ensure robust screen reader comprehension. - Bound `:aria-expanded="isOpen"` to QuickTasks dropdown trigger. - Bound `:aria-expanded="showViewOptions"` to Calendar view options popover. - Bound `:aria-pressed` explicitly to true/false boolean states on the 4 view option toggle buttons (Filters, DoneTasks, FutureRecurring, GoogleEvents) instead of relying solely on visual `.active` classes. Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Added `:aria-expanded` and `:aria-pressed` to interactive components to ensure robust screen reader comprehension. Fixed ESLint failures in Vue components (indentation, unused vars, custom event camelCasing, type assertions). Fixed CI failure by removing deprecated `supabase/setup-cli@v1` action and replacing it with `npx supabase` execution to avoid Node.js version warnings and GitHub API rate limits. Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
Added `:aria-expanded` and `:aria-pressed` to interactive components to ensure robust screen reader comprehension. Fixed ESLint failures in Vue components (indentation, unused vars, custom event camelCasing, type assertions, vue/define-macros-order). Fixed CI failure by removing deprecated `supabase/setup-cli@v1` action and replacing it with `npx supabase` execution to avoid Node.js version warnings and GitHub API rate limits. Updated `scripts/run-e2e.sh` to match. Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
Added `:aria-expanded` and `:aria-pressed` to interactive components to ensure robust screen reader comprehension. Fixed ESLint failures in Vue components (indentation, unused vars, custom event camelCasing, type assertions, vue/define-macros-order, unused variables, singleline-html-element-content-newline warnings). Fixed CI failure by removing deprecated `supabase/setup-cli@v1` action and replacing it with `npx supabase` execution to avoid Node.js version warnings and GitHub API rate limits. Updated `scripts/run-e2e.sh` to match. Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What
Added dynamic
aria-expandedandaria-pressedinteraction states to icon-only toggle buttons and dropdown triggers in the Calendar Header and Quick Tasks menu.🎯 Why
Previously, these buttons only indicated their active state via a visual
.activeCSS class or by rendering a different icon. This meant screen reader users were not being clearly informed if a dropdown was currently open, or if a toggle (like "Show Completed Tasks") was currently pressed/active. Explicitly binding these ARIA attributes ensures correct, semantic state announcements for assistive technology.♿ Accessibility
:aria-expanded="isOpen"to the QuickTasks trigger.:aria-expanded="showViewOptions"to the Calendar view options popover trigger.:aria-presseddirectly to the boolean states of the 4 toggle items (Filters, Done Tasks, Future Recurring, Google Calendar) in the CalendarHeader dropdown.PR created automatically by Jules for task 15781300356545106037 started by @endlessblink