Skip to content

🎨 Palette: ViewControls Accessibility Improvements - #247

Open
endlessblink wants to merge 1 commit into
masterfrom
palette-viewcontrols-a11y-4366436374218107187
Open

🎨 Palette: ViewControls Accessibility Improvements#247
endlessblink wants to merge 1 commit into
masterfrom
palette-viewcontrols-a11y-4366436374218107187

Conversation

@endlessblink

Copy link
Copy Markdown
Owner

💡 What: Added dynamic aria-label, aria-expanded, and aria-pressed attributes to the icon-only toggle buttons ("Filter Toggle" and "Hide Done Tasks") in src/components/layout/ViewControls.vue.

🎯 Why: Icon-only buttons lacking accessible names are difficult or impossible for screen reader users to understand. Additionally, without aria-expanded and aria-pressed, users cannot perceive the current active state of these toggles.

Accessibility:

  • Added :aria-label="showFilters ? 'Hide filters' : 'Show filters'" and :aria-expanded="showFilters" to the Filter Toggle.
  • Added :aria-label="hideDoneTasks ? 'Show completed tasks' : 'Hide completed tasks'" and :aria-pressed="hideDoneTasks" to the Hide Done Tasks toggle.
    These bindings dynamically update alongside their visual state, ensuring a synchronized and intuitive experience for assistive technology users.

PR created automatically by Jules for task 4366436374218107187 started by @endlessblink

Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant