Fix transient task completion sync race - #250
Open
endlessblink wants to merge 7 commits into
Open
Conversation
Constraint: Preserve the existing durable queue and avoid masking genuine missing-task failures. Rejected: Treating a temporarily empty renderer projection as a permanent missing task. Tested: npx vitest run src/composables/tasks/__tests__/useTaskContextMenuActions.spec.ts --maxWorkers=1; npx vitest run tests/contract/task-consistency-failure-matrix.test.ts --maxWorkers=1; npm run test:offline-reconnect-flows; npx vue-tsc --noEmit -p tsconfig.json --composite false
Constraint: Keep missing-migration failures visible after bounded readiness retries. Rejected: Stopping after the first PostgREST schema-cache response. Tested: npx vitest run tests/unit/scripts/local-e2e-schema-preflight.test.ts --maxWorkers=1
Constraint: Fail closed when canonical schema never becomes readable. Rejected: Treat a ten-second GitHub runner warmup as a missing migration. Tested: npx vitest run tests/unit/scripts/local-e2e-schema-preflight.test.ts --maxWorkers=1
Constraint: Keep the disposable CI database authoritative before Realtime E2E. Rejected: Increase schema-cache polling without forcing the runner instance to reload its migrations. Tested: local preflight unit tests; authenticated offline/reconnect matrix; CI canvas-sync rerun pending
Constraint: Keep canonical preflight authenticated against the intended PostgREST role. Rejected: Treat a gateway secret response as proof that canonical tables are absent. Tested: npx vitest run tests/unit/scripts/local-e2e-schema-preflight.test.ts --maxWorkers=1
Constraint: Keep the CI database disposable and load the canonical schema before Realtime E2E. Rejected: Assume a reset restarts PostgREST with a fresh schema snapshot. Tested: local preflight unit tests; CI canvas-sync rerun pending
Constraint: Keep schema preflight fail-closed after bounded canonical contract retries. Rejected: Report a warming RPC schema as a missing table. Tested: npx vitest run tests/unit/scripts/local-e2e-schema-preflight.test.ts --maxWorkers=1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Production deployment remains gated by the Electron build and updater artifact checks.