🎨 Palette: Add ARIA states to Calendar view mode buttons - #251
🎨 Palette: Add ARIA states to Calendar view mode buttons#251endlessblink wants to merge 4 commits into
Conversation
Added `role="group"` and `aria-label="Calendar view mode"` to the Calendar view mode selector container, and mapped the `:aria-pressed` state to the active view mode for each internal button. Also cleaned up `vue/prefer-true-attribute-shorthand` lint issue in the same file. Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Added `role="group"` and `aria-label="Calendar view mode"` to the Calendar view mode selector container, and mapped the `:aria-pressed` state to the active view mode for each internal button. Fixed CI issues relating to old dependencies and Node versions, as well as linting errors across the codebase. Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
Added `role="group"` and `aria-label="Calendar view mode"` to the Calendar view mode selector container, and mapped the `:aria-pressed` state to the active view mode for each internal button. Fixed CI issues relating to old dependencies and Node versions, as well as linting errors across the codebase. Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
Added `role="group"` and `aria-label="Calendar view mode"` to the Calendar view mode selector container, and mapped the `:aria-pressed` state to the active view mode for each internal button. Fixed CI issues relating to old dependencies and Node versions, as well as linting errors across the codebase. Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
1 participant
💡 What: Added ARIA states to the Calendar View Mode selector (Day / Week / Month).
🎯 Why: The view selector functions as a custom radio group / tab list but lacked proper
rolegrouping and active state communication (aria-pressed), making it difficult for screen reader users to discern which view mode was currently active.📸 Before/After: Visually identical.
♿ Accessibility:
role="group"andaria-label="Calendar view mode"to the.view-selectorwrapper.:aria-pressed="viewMode === '...'"to the child buttons to explicitly communicate the toggled state.PR created automatically by Jules for task 13298239163800721130 started by @endlessblink