🎨 Palette: Add ARIA label to ViewControls icon buttons - #252
🎨 Palette: Add ARIA label to ViewControls icon buttons#252endlessblink wants to merge 4 commits into
Conversation
Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…x directly Also fixes various linting issues across the repo to make the CI check pass. Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
…x directly Also fixes various linting issues across the repo to make the CI check pass. Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
…x directly Also fixes various linting issues across the repo to make the CI check pass. Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
💡 What: Added dynamic
:aria-labelattributes to thefilter-toggleanddone-toggleicon-only buttons in the ViewControls component.🎯 Why: Icon-only buttons relying solely on the
titleattribute for accessibility are handled inconsistently by screen readers. Providing an explicitaria-labelensures all users are fully informed of the current active action the button performs.♿ Accessibility: The ARIA labels are bound dynamically (
hideDoneTasks ? 'Show completed tasks' : 'Hide completed tasks') so they match the toggle states exactly and convey their true purpose instead of static descriptions.PR created automatically by Jules for task 642836219335258796 started by @endlessblink