Open
Conversation
Previously the fall_time property had a special case that, if the value is less than zero, the platform would not fall. -1 was the default value. It was exported with @export rather than @export_range, perhaps because the range would have to include a range of negative numbers, all of which would behave the same. Add a new `fall` boolean property, replacing the negative-time meaning of `fall_time`. Group these two properties together in a "Falling Platform" group. Make the `fall` property control whether the other property in the group is visible at all. Change the `fall_time` property to use `@export_range`, and its default value to 2.0. Update the main scene to preserve the previous behaviour.
Member
Author
|
|
Play this branch at https://endlessm.github.io/moddable-platformer/branches/endlessm/wjt/push-komoozttwuln. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Member
Author
|
@jgbourque would this mess up your materials? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the fall_time property had a special case that, if the value is less than zero, the platform would not fall. -1 was the default value. It was exported with @export rather than @export_range, perhaps because the range would have to include a range of negative numbers, all of which would behave the same.
Add a new
fallboolean property, replacing the negative-time meaning offall_time. Group these two properties together in a "Falling Platform" group. Make thefallproperty control whether the other property in the group is visible at all. Change thefall_timeproperty to use@export_range, and its default value to 2.0.Update the main scene to preserve the previous behaviour.