feat: アプリアイコン・通知アイコンの追加とブランドカラーをTealに変更#4
Merged
Merged
Conversation
Add launcher icon resources for all density buckets (mdpi through xxxhdpi) and adaptive icon definitions for API 26+. The icon features a teal chain link on a dark background, generated from icom.jpg. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace broken ic_notification.xml with a proper chain link vector drawable and switch NotificationDisplayer from the system default icon to the custom one. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Switch from Cyan to Teal palette for the primary and secondary theme colors. Dark theme uses Teal300 (#5EEAD4) as primary for better contrast on dark backgrounds. Success indicator color also updated from green to Teal400 to maintain brand consistency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add manifest metadata for Firebase Cloud Messaging to use the custom notification icon and brand color for auto-displayed notifications when the app is in the background. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Generate white silhouette images from the app icon foreground for notification display at all density buckets. This provides a more faithful representation of the chain link design than the hand-crafted vector paths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughAndroidアプリのビジュアル設定とテーマを刷新する変更だね。マニフェストにFCM通知の設定を追加して、アイコンリソースをアダプティブアイコン形式に更新。さらに、デザインテーマのカラーパレットをシアンからティールに切り替えたよ。 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@frontend/shared/src/commonMain/kotlin/dev/plexus/shared/core/ui/theme/Theme.kt`:
- Around line 53-60: The onPrimary and onSecondary contrast is too low against
Teal600/Teal500; replace the hardcoded Color.White for onPrimary and onSecondary
in Theme.kt with a high-contrast color (e.g., Color.Black or a vetted dark
color) or compute content color via a contrast-aware utility so the text against
Teal600/Teal500 meets WCAG AA; update the onPrimary and onSecondary assignments
(symbols: onPrimary, onSecondary, Teal600, Teal500) accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cc826c71-0f97-463e-a3a0-297c3f5998fe
📒 Files selected for processing (23)
frontend/androidApp/src/main/AndroidManifest.xmlfrontend/androidApp/src/main/kotlin/dev/plexus/android/notifications/NotificationDisplayer.ktfrontend/androidApp/src/main/res/drawable-hdpi/ic_notification.webpfrontend/androidApp/src/main/res/drawable-mdpi/ic_notification.webpfrontend/androidApp/src/main/res/drawable-xhdpi/ic_notification.webpfrontend/androidApp/src/main/res/drawable-xxhdpi/ic_notification.webpfrontend/androidApp/src/main/res/drawable-xxxhdpi/ic_notification.webpfrontend/androidApp/src/main/res/drawable/ic_notification.xmlfrontend/androidApp/src/main/res/mipmap-anydpi-v26/ic_launcher.xmlfrontend/androidApp/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xmlfrontend/androidApp/src/main/res/mipmap-hdpi/ic_launcher.webpfrontend/androidApp/src/main/res/mipmap-hdpi/ic_launcher_foreground.webpfrontend/androidApp/src/main/res/mipmap-mdpi/ic_launcher.webpfrontend/androidApp/src/main/res/mipmap-mdpi/ic_launcher_foreground.webpfrontend/androidApp/src/main/res/mipmap-xhdpi/ic_launcher.webpfrontend/androidApp/src/main/res/mipmap-xhdpi/ic_launcher_foreground.webpfrontend/androidApp/src/main/res/mipmap-xxhdpi/ic_launcher.webpfrontend/androidApp/src/main/res/mipmap-xxhdpi/ic_launcher_foreground.webpfrontend/androidApp/src/main/res/mipmap-xxxhdpi/ic_launcher.webpfrontend/androidApp/src/main/res/mipmap-xxxhdpi/ic_launcher_foreground.webpfrontend/androidApp/src/main/res/values/colors.xmlfrontend/shared/src/commonMain/kotlin/dev/plexus/shared/core/ui/theme/DesignTokens.ktfrontend/shared/src/commonMain/kotlin/dev/plexus/shared/core/ui/theme/Theme.kt
💤 Files with no reviewable changes (1)
- frontend/androidApp/src/main/res/drawable/ic_notification.xml
Comment on lines
+53
to
+60
| primary = Teal600, | ||
| onPrimary = Color.White, | ||
| primaryContainer = Cyan100, | ||
| onPrimaryContainer = Cyan950, | ||
| // === Secondary: Cyan === | ||
| secondary = Cyan500, | ||
| primaryContainer = Teal100, | ||
| onPrimaryContainer = Teal950, | ||
| // === Secondary: Teal === | ||
| secondary = Teal500, | ||
| onSecondary = Color.White, | ||
| secondaryContainer = Cyan300, | ||
| onSecondaryContainer = Cyan950, | ||
| secondaryContainer = Teal300, |
There was a problem hiding this comment.
onPrimary/onSecondary の白文字がコントラスト不足
Line 54 と Line 59 の Color.White は、Teal600 / Teal500 背景だと AA(4.5:1) を満たしにくい。小さいテキストやボタンラベルで可読性が落ちる。
修正案（コントラスト改善）
primary = Teal600,
- onPrimary = Color.White,
+ onPrimary = Zinc950,
primaryContainer = Teal100,
onPrimaryContainer = Teal950,
// === Secondary: Teal ===
secondary = Teal500,
- onSecondary = Color.White,
+ onSecondary = Zinc950,
secondaryContainer = Teal300,
onSecondaryContainer = Teal950,🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@frontend/shared/src/commonMain/kotlin/dev/plexus/shared/core/ui/theme/Theme.kt`
around lines 53 - 60, The onPrimary and onSecondary contrast is too low against
Teal600/Teal500; replace the hardcoded Color.White for onPrimary and onSecondary
in Theme.kt with a high-contrast color (e.g., Color.Black or a vetted dark
color) or compute content color via a contrast-aware utility so the text against
Teal600/Teal500 meets WCAG AA; update the onPrimary and onSecondary assignments
(symbols: onPrimary, onSecondary, Teal600, Teal500) accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
icom.jpgから Adaptive Icon（ランチャーアイコン）を生成し、5密度バケット分の mipmap リソースを追加#5EEAD4）Changes
ランチャーアイコン
mipmap-*/ic_launcher.webp— 5密度のレガシーアイコンmipmap-*/ic_launcher_foreground.webp— Adaptive Icon 前景層mipmap-anydpi-v26/ic_launcher.xml— Adaptive Icon 定義values/colors.xml— アイコン背景色#222D32AndroidManifest.xml—android:icon/android:roundIconを設定通知アイコン
drawable-*/ic_notification.webp— 5密度の白シルエット画像NotificationDisplayer.kt—setSmallIconをR.drawable.ic_notificationに変更ブランドカラー
Theme.kt— Cyan パレット → Teal パレットに置き換えDesignTokens.kt— success 色Color(0xFF4CAF50)→Teal400Test plan
./gradlew :androidApp:assembleDebugビルド成功🤖 Generated with Claude Code
Summary by CodeRabbit
リリースノート
スタイル
チョア