fix(security): enforce response-size limits on public analytics endpoints - #491
Open
Emmycivity wants to merge 25 commits into
Open
fix(security): enforce response-size limits on public analytics endpoints#491Emmycivity wants to merge 25 commits into
Emmycivity wants to merge 25 commits into
Conversation
|
@Emmycivity is attempting to deploy a commit to the Cankat's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR enforces bounded response sizes on public analytics endpoints, preventing unbounded collection allocations from user-supplied
limitparameters. It centralizes validation in a shared limit helper, applies route-specific defaults and maximums, preserves aggregate statistics, and returns generic validation errors without leaking internal details.Related Issue
Closes the reported response-size limit security issue for public analytics endpoints.
Changes
🔒 Response-Size Limit Enforcement
[ADD]
web/src/lib/limits.tslimit,defaultLimit, andmaxLimit.[MODIFY] Public analytics route limits
web/src/app/api/events/route.ts— explicit default and response-size cap for event rows.web/src/app/api/ecosystem-intelligence/route.ts— bounded detailed intelligence rows while preserving aggregates.web/src/app/api/activity/route.ts— explicit default and maximum activity items.web/src/app/api/leaderboard/route.ts— explicit default and maximum ranked entries.web/src/app/api/proposals/route.ts— bounded proposal rows with max-limit validation.web/src/app/api/dashboard/route.ts— detailed rows bounded; aggregate statistics remain available.[ADD] Focused route tests
limitvalues, and safe error responses.Verification Results
parseLimitcaps every endpoint before query executionCloses #417