Skip to content

Sync driver_waterstarm.cc with upstream wmbusmeters (commit 8940b208)#3

Merged
enr0c merged 2 commits into
mainfrom
copilot/compare-driver-waterstarm-files
Mar 6, 2026
Merged

Sync driver_waterstarm.cc with upstream wmbusmeters (commit 8940b208)#3
enr0c merged 2 commits into
mainfrom
copilot/compare-driver-waterstarm-files

Conversation

Copilot AI commented Mar 6, 2026

Copy link
Copy Markdown

The local driver_waterstarm.cc was missing one meter detection entry, a backward-flow field at the set date, and two upstream test cases present in wmbusmeters at 8940b208.

Changes

  • New detection: MANUFACTURER_EFE, 0x07, 0x70 — additional EFE meter variant
  • New field extractor: total_backwards_at_set_date — backward flow volume at end of previous billing period (StorageNr(1) + BackwardFlow combinable)
  • New test cases:
    • water 50496629 (AES-encrypted) — exercises total_backwards_at_set_date_m3
    • water2 51398765 (NOKEY) — exercises total_backwards_at_set_date_m3 with FFFFFFFF sentinel values

registerDriver/addDetection/std::shared_ptr are intentional ESPHome fork adaptations and are left unchanged vs upstream's staticRegisterDriver/addMVT/shared_ptr.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/wmbusmeters/wmbusmeters/contents/src/driver_sensostar.cc
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: enr0c <33492932+enr0c@users.noreply.github.com>
Copilot AI changed the title [WIP] Compare driver_waterstarm.cc file with GitHub version Sync driver_waterstarm.cc with upstream wmbusmeters@8940b208 Mar 6, 2026
Copilot finished work on behalf of enr0c March 6, 2026 20:34
Copilot AI changed the title Sync driver_waterstarm.cc with upstream wmbusmeters@8940b208 Sync driver_waterstarm.cc with upstream wmbusmeters (commit 8940b208) Mar 6, 2026
Copilot finished work on behalf of enr0c March 6, 2026 20:50
@enr0c enr0c marked this pull request as ready for review March 6, 2026 21:10
@enr0c enr0c merged commit e5acbab into main Mar 6, 2026
1 check passed
@enr0c enr0c deleted the copilot/compare-driver-waterstarm-files branch March 13, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants