Sync driver_waterstarm.cc with upstream wmbusmeters (commit 8940b208)#3
Merged
Merged
Conversation
Co-authored-by: enr0c <33492932+enr0c@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Compare driver_waterstarm.cc file with GitHub version
Sync driver_waterstarm.cc with upstream wmbusmeters@8940b208
Mar 6, 2026
Copilot
AI
changed the title
Sync driver_waterstarm.cc with upstream wmbusmeters@8940b208
Sync driver_waterstarm.cc with upstream wmbusmeters (commit 8940b208)
Mar 6, 2026
enr0c
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local
driver_waterstarm.ccwas missing one meter detection entry, a backward-flow field at the set date, and two upstream test cases present in wmbusmeters at8940b208.Changes
MANUFACTURER_EFE, 0x07, 0x70— additional EFE meter varianttotal_backwards_at_set_date— backward flow volume at end of previous billing period (StorageNr(1) +BackwardFlowcombinable)water 50496629(AES-encrypted) — exercisestotal_backwards_at_set_date_m3water2 51398765(NOKEY) — exercisestotal_backwards_at_set_date_m3withFFFFFFFFsentinel valuesWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/wmbusmeters/wmbusmeters/contents/src/driver_sensostar.cc/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(http block)If you need me to access, download, or install something from one of these locations, you can either:
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.