Open
Conversation
aocneanu
reviewed
Feb 12, 2021
| }); | ||
| }, | ||
| readRequest(method, exportMode = false, selection = false) { | ||
| fetchRow(dtRowId) { |
Contributor
There was a problem hiding this comment.
can't we reuse most part of fetch()?
Member
Author
There was a problem hiding this comment.
I tried to do it but the final code was a bit dirtier. because fetchRow() has something in the middle of the method and for refactoring this we should refactor methods to many tiny methods but it makes our class a little complicated(because it isn't SRP!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@aocneanu also money was removed.