Skip to content

Don't override the user's debug configuration #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodeCommander wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Don't override the user's debug configuration #23

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a14601
Don't override the user's debug configuration in case they want to se…
CodeCommander Jun 9, 2015
d3c68b5
Merge commit '4a146018f9dbc6d5f47b53a8f7c7aef73e76b236' into develop
CodeCommander Jun 9, 2015
2794a95
We really don't want to send a 500 error for anything except json wit…
CodeCommander Aug 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions jsonAPI/JsonApiMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ class JsonApiMiddleware extends \Slim\Middleware {
function __construct(){

$app = \Slim\Slim::getInstance();
$app->config('debug', false);

// Mirrors the API request
$app->get('/return', function() use ($app) {
Expand Down Expand Up @@ -63,9 +62,10 @@ function __construct(){

// Handle Empty response body
$app->hook('slim.after.router', function () use ($app) {
//Fix sugested by: https://github.com/bdpsoft
//Will allow download request to flow
if($app->response()->header('Content-Type')==='application/octet-stream'){

// don't render an empty response warning
// if we have specified another content-type
if($app->response()->header('Content-Type')!=='application/json'){
return;
}

Expand Down