Depth of Market: include all quoted rates, not just those with collateral#88
Closed
e35ventura wants to merge 1 commit into
Closed
Depth of Market: include all quoted rates, not just those with collateral#88e35ventura wants to merge 1 commit into
e35ventura wants to merge 1 commit into
Conversation
…eral Active miners whose collateral is fully locked in an in-flight swap show collateralRao=0 in the miners feed. The depth chart was filtering those out entirely, so the orderbook collapsed to a single row even when the Active Rates table clearly listed more. Keep the rate level in the depth groupings regardless of collateral, and contribute the miner's actual capacity (zero if locked). Bars only fill where there is real capacity; otherwise the row is still present so the quoted rate is visible.
Collaborator
Author
|
Closing — misread the data. Only one miner has non-zero collateral, so a single row is the correct depth representation. The original filter was right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collateralRaoreports as0, so the entire row was filtered out). The Active Rates table kept showing the rate, so the two views disagreed.Test plan
https://api.all-ways.io(two miners: one with active swap + 0 collateral, one with collateral).