refactor: use apply_fee_deduction in hydrate_pending_swap (#334)#335
Open
alpurkan17 wants to merge 1 commit into
Open
refactor: use apply_fee_deduction in hydrate_pending_swap (#334)#335alpurkan17 wants to merge 1 commit into
alpurkan17 wants to merge 1 commit into
Conversation
alpurkan17
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
hydrate_pending_swapinallways/cli/swap_commands/helpers.pyinlines the fee math instead of using the sharedapply_fee_deductionhelper fromallways/utils/rate.py. Other CLI sites (swap.py,quote.py) already route through this helper.This removes the only remaining inline copy, eliminating a drift point if the fee formula ever changes.
Changes
state.to_amount - state.to_amount // FEE_DIVISORwithapply_fee_deduction(state.to_amount, FEE_DIVISOR)FEE_DIVISORimport to top-level (removed local import workaround)apply_fee_deductionimport fromallways.utils.rateCloses #334