Skip to content

fix(webhook): use installation_id in uninstall cleanup#107

Draft
leno23 wants to merge 1 commit into
entrius:testfrom
leno23:fix/installation-deleted-column-92
Draft

fix(webhook): use installation_id in uninstall cleanup#107
leno23 wants to merge 1 commit into
entrius:testfrom
leno23:fix/installation-deleted-column-92

Conversation

@leno23
Copy link
Copy Markdown

@leno23 leno23 commented May 17, 2026

Summary

  • Fix installation.deleted cleanup to filter by the actual database column name installation_id.
  • Keep the existing soft-clear behavior: set installationId to null and registered to false for repos owned by the deleted installation.

Related Issues

Closes #92

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (describe below)

Testing

  • npm ci
  • npm run build
  • npm run lint
  • npm run format:check
  • git diff --check HEAD~1 HEAD

Note: this repository does not currently define a test script/test runner in packages/das/package.json, so I validated with the available build, lint, formatting, and whitespace gates.

Checklist

  • I have read the Contributing Guide
  • Code builds without errors
  • New and existing tests pass (if applicable)
  • Documentation updated (if applicable)
  • No unnecessary dependencies added

AI assistance disclosure

This draft PR was prepared with AI assistance. The change is intentionally limited to the uninstall cleanup query column name and was validated with the commands above.

@xiao-xiao-mao xiao-xiao-mao Bot added the bug Something isn't working label May 17, 2026
@anderdc
Copy link
Copy Markdown
Collaborator

anderdc commented May 17, 2026

why is this marked as a draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Uninstall cleanup query uses wrong column name for installation ID

2 participants