Fix backfill race for issue solved_by_pr linkage#29
Closed
owldev127 wants to merge 1 commit into
Closed
Conversation
adacd81 to
640ac35
Compare
Collaborator
|
The backfill race here is fixed by moving |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #28
Summary
This PR fixes a backfill ordering bug where
issues.solved_by_prcould remain null even when a merged PR already referenced the issue in its closing links.The root problem is that PR backfill and issue backfill have different responsibilities:
closingIssueNumbersissuesrows thatsolved_by_pris written ontoWithout backfilling issues first, the mirror cannot safely reconcile
issues.solved_by_pr:solved_by_pr)Fix
closingIssueNumbersduring initial PR backfillissues.solved_by_prfrom merged PR closing links after both PR and issue rows existWhy still
backfillIssues()Is RequiredbackfillPullRequests()alone is not enough. It tells us which PRs claim to close which issues, but it does not guarantee that the corresponding issue rows exist or are current in the database.solved_by_prsolved_by_prType of Change
Testing
Checklist