Skip to content

fix: normalize repoFullName to lowercase in validateRepoFullName #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anderdc merged 1 commit into from
May 17, 2026
Merged

fix: normalize repoFullName to lowercase in validateRepoFullName #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/das/src/api/admin.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,12 @@ export class AdminController {
}> {
const repoFullName = validateRepoFullName(body?.repoFullName);

const result = await this.repoRepo.update(
{ repoFullName },
{ registered: true },
);
const result = await this.repoRepo
.createQueryBuilder()
.update()
.set({ registered: true })
.where("LOWER(repo_full_name) = LOWER(:repoFullName)", { repoFullName })
.execute();

if (!result.affected) {
throw new NotFoundException(
Expand Down
7 changes: 6 additions & 1 deletion packages/das/src/webhook/github-fetcher.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,12 @@ export class GitHubFetcherService implements OnModuleInit {
}

private async getTokenForRepo(repoFullName: string): Promise<string> {
const repo = await this.repoRepo.findOneBy({ repoFullName });
const repo = await this.repoRepo
.createQueryBuilder("repo")
.where("LOWER(repo.repo_full_name) = LOWER(:repoFullName)", {
repoFullName,
})
.getOne();
if (!repo?.installationId) {
throw new Error(`No installation for repo ${repoFullName}`);
}
Expand Down
Loading