Skip to content

fix: allowing unknown solvers through mirror solved-issue pipeline#87

Open
jonathanchang31 wants to merge 1 commit into
entrius:testfrom
jonathanchang31:fix/missing-pr-author-null
Open

fix: allowing unknown solvers through mirror solved-issue pipeline#87
jonathanchang31 wants to merge 1 commit into
entrius:testfrom
jonathanchang31:fix/missing-pr-author-null

Conversation

@jonathanchang31
Copy link
Copy Markdown

Summary

This change fixes a scoring-integrity bug where backfill stored missing PR author IDs as empty strings ('') instead of NULL. Because solver selection only filtered IS NOT NULL, unknown solver identities leaked into solving_pr.

Related Issue

Fixes: #85

Change Type (select all)

  • Bug fix
  • Data integrity fix
  • API response correctness fix
  • Backfill pipeline correction
  • DB data normalization script
  • Breaking change
  • New feature

Root Cause

  • Backfill PR upsert used:
    • authorGithubId: String(pr.author?.databaseId ?? "")
  • Empty string passed solver guard:
    • sp.author_github_id IS NOT NULL

Result: unknown solver IDs ('') were treated as present and returned in solved-issue pipeline.

Real Behavior Proof

Before

  • Missing PR author in backfill -> author_github_id = ''
  • Solver subquery accepted it (IS NOT NULL true)
  • API could emit solved issues with unknown/blank solver identity

After

  • Missing PR author in backfill -> author_github_id = NULL
  • Solver subquery rejects both null and blank IDs
  • Unknown solvers are excluded from solving_pr as intended

Checklist

  • Fix implemented in backfill PR ingestion path
  • Solver SQL guard hardened for blank values
  • Legacy normalization SQL added
  • Patch re-validated by code inspection
  • Migration applied in target DB environment
  • Tests run in CI/local

@xiao-xiao-mao xiao-xiao-mao Bot added the bug Something isn't working label May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] backfill stores missing PR author as empty string, allowing unknown solvers through mirror solved-issue pipeline

1 participant