fix(backfill): create issue rows before PR metadata jobs#95
Open
JSONbored wants to merge 1 commit into
Open
Conversation
Move issue backfill ahead of PR metadata and file job enqueueing so metadata jobs can resolve solved_by_pr links during backfill. Fixes entrius#28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed
handleBackfill()now callsbackfillIssues()immediately after PR backfill completes.Why
PR metadata jobs can only link
solved_by_prwhen the referenced issue rows already exist. Enqueueing metadata jobs before issue backfill can leave already-seen PRs without issue attribution during backfill.Fixes #28
Validation
npm cinpm run buildnpm run lintnpm run format:checkgit diff --check