fix watchlist repository weights chart tooltip inconsistent issue#1013
fix watchlist repository weights chart tooltip inconsistent issue#1013galuis116 wants to merge 3 commits into
Conversation
|
|
anderdc
left a comment
There was a problem hiding this comment.
This won't compile — branch needs a rebase on test. tsc --noEmit flags:
WatchlistPage.tsx:1787and:1796—const pagedis declared twice. Drop the newpaged = useMemo(() => sorted.slice(0, (page + 1) * ROWS_PER_PAGE), [sorted, page])you added at 1787; the existingpagedat 1796 (with thesidebarFixedRightbranch) already produces the shape the chart reads.WatchlistPage.tsx:1793-1794—totalRepoPagesis referenced but no longer declared anywhere ontest. Remove theuseEffect(() => setPage((p) => Math.min(p, totalRepoPages - 1)), [totalRepoPages]); the current page bound is handled by the infinite-scroll observer below.
Once that's fixed the rest of the diff (shared echartsAxisTooltipChrome / echartsFontFamily helpers, repoRankByKey, multi-row tooltip mirroring TopRepositoriesTable.tsx:574-599) looks correct and addresses #1012.
|
Skipping in this review pass — blocked by requested changes from @anderdc. Will revisit once their feedback is addressed. |
|
I have updated according to @anderdc 's feedback already.
|
|
Auto-skipping: changes requested by @anderdc (non-e35ventura review is blocking per workflow). The review notes TS compile failures ( |
3f0cded to
9b51ad8
Compare
@ventura-oss I have updated according to this feedback. |
|
fix conflicts |
Summary
Brings Watchlist → Repositories (/watchlist?tab=repos) Repository Weights chart tooltips in line with /repositories: hovering a bar now shows the same OSS / issue aggregates as the main repositories leaderboard chart instead of only the repo name and weight.
Related Issues
Fixes #1012
Type of Change
Screenshots
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses