Skip to content

fix watchlist repository weights chart tooltip inconsistent issue#1013

Open
galuis116 wants to merge 3 commits into
entrius:testfrom
galuis116:fix/watchlist-repository-weights-chart-tooltip
Open

fix watchlist repository weights chart tooltip inconsistent issue#1013
galuis116 wants to merge 3 commits into
entrius:testfrom
galuis116:fix/watchlist-repository-weights-chart-tooltip

Conversation

@galuis116
Copy link
Copy Markdown
Contributor

@galuis116 galuis116 commented May 10, 2026

Summary

Brings Watchlist → Repositories (/watchlist?tab=repos) Repository Weights chart tooltips in line with /repositories: hovering a bar now shows the same OSS / issue aggregates as the main repositories leaderboard chart instead of only the repo name and weight.

Related Issues

Fixes #1012

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (describe below)

Screenshots

2026-05-09_23h44_11 2026-05-09_23h44_45

Checklist

  • New components are modularized/separated where sensible
  • Uses predefined theme (e.g. no hardcoded colors)
  • Responsive/mobile checked
  • Tested against the test API
  • npm run format and npm run lint:fix have been run
  • npm run build passes
  • Screenshots included for any UI/visual changes

@xiao-xiao-mao xiao-xiao-mao Bot added the enhancement New feature or request label May 10, 2026
@ventura-oss
Copy link
Copy Markdown
Contributor

ventura-oss commented May 10, 2026

⚠️ Skipped during review — No CI checks have run on this PR. CI requires maintainer approval for first-time contributors and won't auto-run regardless of new pushes. A maintainer will approve the workflow run when ready to review.

Copy link
Copy Markdown
Collaborator

@anderdc anderdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't compile — branch needs a rebase on test. tsc --noEmit flags:

  • WatchlistPage.tsx:1787 and :1796const paged is declared twice. Drop the new paged = useMemo(() => sorted.slice(0, (page + 1) * ROWS_PER_PAGE), [sorted, page]) you added at 1787; the existing paged at 1796 (with the sidebarFixedRight branch) already produces the shape the chart reads.
  • WatchlistPage.tsx:1793-1794totalRepoPages is referenced but no longer declared anywhere on test. Remove the useEffect(() => setPage((p) => Math.min(p, totalRepoPages - 1)), [totalRepoPages]); the current page bound is handled by the infinite-scroll observer below.

Once that's fixed the rest of the diff (shared echartsAxisTooltipChrome / echartsFontFamily helpers, repoRankByKey, multi-row tooltip mirroring TopRepositoriesTable.tsx:574-599) looks correct and addresses #1012.

@ventura-oss
Copy link
Copy Markdown
Contributor

Skipping in this review pass — blocked by requested changes from @anderdc. Will revisit once their feedback is addressed.

@galuis116
Copy link
Copy Markdown
Contributor Author

I have updated according to @anderdc 's feedback already.

This won't compile — branch needs a rebase on test. tsc --noEmit flags:

  • WatchlistPage.tsx:1787 and :1796const paged is declared twice. Drop the new paged = useMemo(() => sorted.slice(0, (page + 1) * ROWS_PER_PAGE), [sorted, page]) you added at 1787; the existing paged at 1796 (with the sidebarFixedRight branch) already produces the shape the chart reads.
  • WatchlistPage.tsx:1793-1794totalRepoPages is referenced but no longer declared anywhere on test. Remove the useEffect(() => setPage((p) => Math.min(p, totalRepoPages - 1)), [totalRepoPages]); the current page bound is handled by the infinite-scroll observer below.

Once that's fixed the rest of the diff (shared echartsAxisTooltipChrome / echartsFontFamily helpers, repoRankByKey, multi-row tooltip mirroring TopRepositoriesTable.tsx:574-599) looks correct and addresses #1012.

@ventura-oss
Copy link
Copy Markdown
Contributor

Auto-skipping: changes requested by @anderdc (non-e35ventura review is blocking per workflow). The review notes TS compile failures (WatchlistPage.tsx:1787 and :1796 duplicate paged, dangling totalRepoPages reference). Will revisit once those are resolved and the rebase lands.

@galuis116 galuis116 force-pushed the fix/watchlist-repository-weights-chart-tooltip branch from 3f0cded to 9b51ad8 Compare May 14, 2026 00:26
@galuis116
Copy link
Copy Markdown
Contributor Author

Auto-skipping: changes requested by @anderdc (non-e35ventura review is blocking per workflow). The review notes TS compile failures (WatchlistPage.tsx:1787 and :1796 duplicate paged, dangling totalRepoPages reference). Will revisit once those are resolved and the rebase lands.

@ventura-oss I have updated according to this feedback.

@anderdc
Copy link
Copy Markdown
Collaborator

anderdc commented May 15, 2026

fix conflicts

@galuis116 galuis116 requested a review from anderdc May 15, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants