feat : Standardize miner table pagination and shared pager UX#1059
Open
carlh7777 wants to merge 1 commit into
Open
feat : Standardize miner table pagination and shared pager UX#1059carlh7777 wants to merge 1 commit into
carlh7777 wants to merge 1 commit into
Conversation
Contributor
|
Skipping in this review pass — branch has merge conflicts against current |
carlh7777
force-pushed
the
feat/miner-pagination
branch
from
60c3676 to
cf862ed
Compare
Contributor
Author
|
Hi @ventura-oss Rebased onto the latest origin/test, resolved the merge conflicts, and force-pushed the updated branch for re-review. |
carlh7777
force-pushed
the
feat/miner-pagination
branch
2 times, most recently
from
f98a638 to
3b31267
Compare
Collaborator
|
fix conflicts |
…Table and MinerRepositoriesTable
carlh7777
force-pushed
the
feat/miner-pagination
branch
from
3b31267 to
f466de5
Compare
Contributor
Author
|
Hi @anderdc fixed conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TablePagination.tsx.Type of Change
Screenshots
Before
Before.webm
After
After.webm
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses