fix: reserve space for sort indicator to prevent header layout shift (#995)#1132
Open
alpurkan17 wants to merge 3 commits into
Open
fix: reserve space for sort indicator to prevent header layout shift (#995)#1132alpurkan17 wants to merge 3 commits into
alpurkan17 wants to merge 3 commits into
Conversation
Author
|
@anderdc @LandynDev ready for review |
anderdc
requested changes
May 15, 2026
Collaborator
anderdc
left a comment
There was a problem hiding this comment.
Please scope this down to what #995 asks for. Keep: the DataTable.tsx sort-indicator fix — whiteSpace nowrap on the header cell and the TableSortLabel icon opacity/width sx. Drop: the linkBehavior.tsx LinkTableRow rewrite and the getRowHref JSDoc change in DataTable.tsx. Those are unrelated to #995 — and they're the same LinkTableRow change as PR #1130 / issue #1127, which were closed as not planned.
…kTableRow rewrite
Author
Author
|
Scoped down per review — DataTable.tsx sort-indicator fix only, linkBehavior.tsx removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking a sortable column header causes the header row to reflow because the
TableSortLabelicon appears/disappears dynamically, pushing cell content and triggering width recalculation.Add
white-space: nowrapon the header cell to prevent text reflow, and reservewidth: 18pxfor the sort icon (opacity 0 when inactive) so the space is always accounted for in the layout.Validation
npm run lint— cleannpm run test— 27 passedCloses #995