Skip to content

fix(back-button): require same-origin referrer before stepping browser history, so fresh-tab Back falls back to the in-app route #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pandadev66 wants to merge 1 commit into
base: test
Choose a base branch
from
+11 −1
Open

fix(back-button): require same-origin referrer before stepping browser history, so fresh-tab Back falls back to the in-app route #1160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/components/BackButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,17 @@ const BackButton: React.FC<BackButtonProps> = ({
const navigate = useNavigate();
const location = useLocation();
const state = (location.state as { backTo?: string }) || {};
const canGoBack = typeof window !== 'undefined' && window.history.length > 1;
const canGoBack = (() => {
if (typeof window === 'undefined') return false;
if (window.history.length <= 1) return false;
const ref = document.referrer;
if (!ref) return false;
try {
return new URL(ref).origin === window.location.origin;
} catch {
return false;
}
})();

const handleClick = () => {
if (canGoBack) {
Expand Down
Loading