feat: repository issues table toolbar#1163
Open
andriypolanski wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Hi @anderdc, First of all, thanks for taking the time to review. I opened this PR as an updated version because #738 was closed without being resolved. Please review it when you have a chance. If there are any other issues, feel free to leave a comment and I’ll fix them as soon as possible. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repository Issues table toolbar lacked client-side search, filter pills had uneven label/count presentation, and the header layout did not adapt well on small screens (no compact search entry point, filters competing with the title on one wrapped row).
Related Issues
Closes #1164
Type of Change
Screenshots
Before
before.mp4
After
after.mp4
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpassesSolution
Files
src/components/repositories/RepositoryIssuesTable.tsxsrc/components/FilterButton.tsx