Keep miner score controls visible without PRs#1171
Open
longbiaochen wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the “blank PR breakdown” UI for miners with zero PRs by ensuring the PrBreakdownView still renders the Score Breakdown card and its toolbar controls (filters, rows selector, search) even when the PR list is empty, matching the expected empty-state behavior described in issue #1133.
Changes:
- Stop returning
nullwhenprs.length === 0, allowing the existing empty-state message (“No PRs to show.” / “No PRs match your search.”) to render. - Preserve the filter buttons, rows-per-page selector, and search input for the empty PR case.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1133
Verification
http://localhost:8080/miners/details?githubId=94741984&mode=prs&tab=overviewwith test API data where/miners/94741984/prsreturns an empty array; observed Score Breakdown, All/Open/Merged/Closed filters, Rows selector, search input, andNo PRs to show.