fix: show in-view rank indicator when leaderboard filters are active (#1102)#1174
Open
alpurkan17 wants to merge 1 commit into
Open
fix: show in-view rank indicator when leaderboard filters are active (#1102)#1174alpurkan17 wants to merge 1 commit into
alpurkan17 wants to merge 1 commit into
Conversation
…ntrius#1102) Add viewRank field to MinerStats — computed as the 1-indexed position within the filtered subset when a search or eligibility filter is active. MinersList rank cell and MinerCard rank line now display a subtle "·N in view" indicator beside the global rank when the two diverge.
Author
|
@anderdc @LandynDev ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Rank column on Top Miners / Discoveries leaderboards always shows the global rank. When a filter is active, consecutive rows show gaps (16, 19, 23, 48, 94) with no UI indication that the gaps are caused by filtered-out miners. Users reasonably interpret this as a bug.
Fix (Option A): add a subtle "·N in view" indicator next to the global rank when filters are active and the two ranks diverge.
Changes
viewRanktoMinerStats— 1-indexed position in filtered subsetviewRankonly when a search/eligibility filter is active·{viewRank}beside the RankIcon in list view·{viewRank} in viewnext to the global rank on cardsEdge cases
Validation
viewRank != nullbefore comparisonCloses #1102