Repository details — GitHub-aligned Issues / PR tab icons (Octicons)#1178
Open
andriypolanski wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Hi, @anderdc Unexpectedly I updated many versions of package-lock.json file while installing new module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repository details page tabs for Issues and Pull Requests used Material UI icons that did not match github.com:
BugReportIconfor Issues andMergeTypeIconfor PRs. That created an inconsistent meaning for anyone toggling between GitHub and Gittensor.Related Issues
Closes #1179
Type of Change
Screenshots
Before
Untitled273.mp4
After
after.mp4
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpassesSolution
IssueOpenedIconandGitPullRequestIconfrom@primer/octicons-react.BugReportIconand the Pull Requests tabMergeTypeIconinRepositoryDetailsPage.tsx.Boxcomponent="span"withdisplay: 'inline-flex',alignItems: 'center',mr: 1, andcolor: 'inherit'so size (16) and spacing stay consistent with other tabs and the SVG picks up the tab’s text color.Files
src/pages/RepositoryDetailsPage.tsxpackage.json@primer/octicons-react(if not already present in the branch)