fix: prevent double-counting PRs in dashboard overview pool#1199
Closed
zp6 wants to merge 2 commits into
Closed
Conversation
Fixes entrius#1176 The Watchlist Issues tab was passing useMinersIssues without a since parameter, causing the mirror API to return only OPEN issues. Resolved and Closed filters always showed 0 results. Added a stable since timestamp (35 days back, memoized) so the mirror returns issues across all states. Same pattern used by the dashboard.
Fixes entrius#1180 getPrOverviewMetrics ran three independent if-branches for createdInWindow / mergedInWindow / closedInWindow, so a PR created and merged in the same window counted as both Open and Merged (+2 Total). Changed to if/else-if chain so each PR contributes to exactly one bucket: Merged takes priority (terminal state), then Closed, then Open.
Collaborator
|
Duplicate of #1181 which is better scoped/implemented. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1180
getPrOverviewMetrics ran three independent if branches for createdInWindow / mergedInWindow / closedInWindow. A PR created and merged in the same window counted as both Open and Merged (+2 to Total).
Fix: Changed to if / else if chain so each PR contributes to exactly one bucket. Merged takes priority (terminal state), then Closed, then Open.
Result: Total === Merged + Open + Closed for all windows.