Skip to content

Migrating setup.py and setup.cfg to UV package manager and Travis to GitHub Actions#106

Open
ok-lch wants to merge 12 commits intoenvironmentalscience:masterfrom
ok-lch:master
Open

Migrating setup.py and setup.cfg to UV package manager and Travis to GitHub Actions#106
ok-lch wants to merge 12 commits intoenvironmentalscience:masterfrom
ok-lch:master

Conversation

@ok-lch
Copy link
Copy Markdown

@ok-lch ok-lch commented Feb 16, 2026

Hello @schymans 😄

Here is some changes that can give a good start to help fixing #91.
Its not perfect yet but I think its a good start.

I have change the dependencies management system to use uv, moving from setup.py and setup.cfg files to a pyproject.toml file.

I removed Travis pipeline to use GitHub Actions.
Tests are running and passing for python version 3.8 and 3.9.
There is still two jobs that need some tinkering (publishing the documentation and the package).

I haven't done many upgrades on dependencies.
Only one fix regarding pkg_resources in _generator.py

I have put some documentation in the CONTRIBUTING.md file but I think it may not be the right place as I have seen later that there it should fit better in docs/installation.rst in the Development section.

Kind regards,
Laurent

Copy link
Copy Markdown
Collaborator

@schymans schymans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing work, thank you! I had trouble running the tests at first and left a comment in the file contributing.md where you described what to do. Perhaps this could be clarified before merging? I also had some warnings when building the docs, did you see these, too?

Comment thread CONTRIBUTING.md
- `uv sync --group tests` (to install pytest and execute test)
- `uv sync --group docs` (to install sphinx)
- `uv sync --group generator` (to install yapf)
- `uv sync --all-groups` (to install all extra dependencies)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only been able to successfully run the tests after running uv sync --all-groups . uv sync --group tests was also sufficient to run the tests, but they failed because of the missing yapf, whereas uv sync --group generator somehow uninstalled pytest again, so couldn't run tests any more. Perhaps I am misunderstanding uv, but others might have the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants