Fix release verification step failing on a missing import - #19
Merged
Merged
Conversation
The v0.2.2 release build reached the new install-and-verify gate and died with ModuleNotFoundError: No module named 'openfov'. The build job installs requirements-dev.txt but never `pip install -e .` -- only the CI workflow does -- so the package was not importable when the step called ensure_registered(). Set PYTHONPATH for that step rather than adding an editable install to the job. An editable install would land before the ~35 minute Nuitka build and change the environment it resolves imports in; there is no reason to risk that to satisfy one verification step. Worth recording what the gate proved before it broke: the installer built, installed silently, and shipped both NPClient64.dll and TrackIR.exe -- those checks all passed. And it correctly refused to publish, so no broken release went out. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
v0.2.2release build (run 31911018012) reached the new install-and-verify gate and failed with:The
buildjob installsrequirements-dev.txtbut neverpip install -e .— only the CI workflow does — so the package wasn't importable when the step calledensure_registered().Fixed by setting
PYTHONPATHfor that step only, rather than adding an editable install to the job. An editable install would land before the ~35 minute Nuitka build and change the environment it resolves imports in; not worth that risk to satisfy one verification step.What the gate proved before it broke
Everything up to the import passed on a real runner:
NPClient64.dllandTrackIR.exepresent inC:\Program Files\OpenFOV\resources\binAnd it correctly refused to publish — no release, no artifact upload. Nothing broken shipped.
Verified locally
The exact failing command now succeeds:
No
v0.2.2release exists, so once this merges thev0.2.2tag can be moved to the new commit rather than burning a version number on a CI-only fix.