flex/grid+sass#6
Open
kulikov98 wants to merge 3 commits into
Open
Conversation
mariia-zu
reviewed
Jul 22, 2019
mariia-zu
left a comment
mariia-zu
left a comment
There was a problem hiding this comment.
Very well =)
Please, fix version with grid
|
|
||
| .weather-widget__top-info { | ||
| @include flex(space-between, center); | ||
| padding-bottom: 5%; |
There was a problem hiding this comment.
In this file you should position elements using only grid
| } | ||
|
|
||
| .weather-widget__degrees { | ||
| @include flex; |
There was a problem hiding this comment.
Here and everywhere in this file you should remove all rules connecting with flex
| <div class="weather-widget__bottom-info"> | ||
| <span class="weather-widget__wind">2 MPH</span> | ||
| <span class="weather-widget__humidity">33%</span> | ||
| <span class="weather-widget__clear">83%</span> |
| } | ||
|
|
||
| &__dot_active { | ||
| @extend .weather-widget__dot; |
| } | ||
|
|
||
| &__clear { | ||
| @extend %bottom-icon; |
There was a problem hiding this comment.
You can do like this, it's up to you.
In my opinion it's easier to add the same class for these elements and describe this class here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.