1116: Extend multivariate scoring vignette with energy vs variogram comparison#1193
Open
kathsherratt wants to merge 8 commits into
Open
1116: Extend multivariate scoring vignette with energy vs variogram comparison#1193kathsherratt wants to merge 8 commits into
kathsherratt wants to merge 8 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This reverts commit 1f6d33e.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
=======================================
Coverage 98.15% 98.15%
=======================================
Files 41 41
Lines 2225 2225
=======================================
Hits 2184 2184
Misses 41 41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
purrr is in Imports but not attached in the vignette, so the qualified call is required for the example to run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Author
|
I wanted to keep this PR very light, but noting a couple of ideas for further development -
|
nikosbosse
approved these changes
Jul 18, 2026
nikosbosse
left a comment
Collaborator
There was a problem hiding this comment.
Nice, thank you!
Should we warn more explicitly about multivariate quantile scores in the code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The aim of this PR is to lightly expand the multivariate scoring vignette and add a comparison between the energy score and the variogram score on some example data. For me, the problem of autocorrelation by forecast horizon is the most obvious and intuitive/compelling use case for multivariate scores, so wanted to include something on that (as well as the existing vignette with spatial dependence).
This PR relates to #1116 (now closed) and various others related to enenrgy/variogram scores.
Changes to
vignettes/scoring-multivariate-forecasts.Rmd:joint_across = c("horizon", "target_end_date")) so each score covers a whole trajectory.Also adds a NEWS item.
Checklist
lintr::lint_package()to check for style issues introduced by my changes (no lints in the changed vignette).Dev: I designed this, implemented, then used iterative LLM support