feat(daemon): auto-reconnect when CDP WebSocket closes#193
Open
Hexthebaldy wants to merge 1 commit intoepiral:mainfrom
Open
feat(daemon): auto-reconnect when CDP WebSocket closes#193Hexthebaldy wants to merge 1 commit intoepiral:mainfrom
Hexthebaldy wants to merge 1 commit intoepiral:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #180
Problem
When Chrome closes or restarts, the CDP WebSocket drops and the daemon
permanently returns HTTP 503 for all subsequent commands. Users must
manually restart both Chrome and the daemon to recover.
Solution
Add auto-reconnect logic to
CdpConnection. When the WebSocket closesunexpectedly, the daemon retries the connection every 5 seconds until
Chrome becomes available again. Commands arriving during reconnect are
queued via
waitUntilReady()instead of failing immediately.Key changes in
packages/daemon/src/cdp-connection.ts:intentionalCloseflag distinguishes graceful shutdown from unexpecteddisconnects — only the latter triggers reconnect
scheduleReconnect()clears stale session state and callsconnect()on a fixed 5s interval
waitUntilReady()queues callers when a reconnect is in progressinstead of rejecting with the last error
disconnect()cancels any pending reconnect timerpackages/daemon/src/http-server.ts:/statusendpoint exposescdpReconnectingfieldScreenshots
Chrome killed → auto-reconnect → Chrome restarted → recovered