Only deploy root docs to website on release builds#88
Merged
Conversation
The "Deploy root docs to website" step ran on every push to main, overwriting the site root with snapshot-version instructions. Tighten its condition from excluding pull requests to requiring a v* tag push (release builds), so only releases update the root docs; "Deploy dokka to website" still runs on main pushes too. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ln68zwMS12XmqUefnBypep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
publishjob inpublish-artifacts.ymlruns on every push tomainas well as onv*release tags, and the "Deploy root docs to website" step only excluded pull requests. Every merge tomaintherefore redeployed the site root with the current snapshot version's instructions, clobbering the latest release's docs.Fix
Tighten the step's condition to
if: github.ref_type == 'tag', so the site root is only updated by release builds (thev*tag pushed from a release branch when shipping). Tag pushes are never pull requests, so the previous PR exclusion is preserved. "Deploy dokka to website" is intentionally unchanged — it still runs on pushes tomain(deploying to/docs/main/) as well as on release tags.Same fix as episode6/redux-store-flow#115.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ln68zwMS12XmqUefnBypep