Consolidate DatapipeApp: drop Pipeline, move build_compute/run_steps into the class - #432
Closed
elephantum wants to merge 1 commit into
Closed
elephantum wants to merge 1 commit into
elephantum wants to merge 1 commit into
Conversation
…into the class `Pipeline` was a one-field wrapper around `Sequence[PipelineStep]` with no behavior; `build_compute`/`run_steps`/`run_steps_changelist`/`run_pipeline`/ `run_changelist` were free functions in datapipe.compute that every real caller (CLI, datapipe-app, examples) reached by manually unpacking an already-in-scope DatapipeApp instance. - DatapipeApp.__init__ now takes `pipeline: Sequence[PipelineStep]` directly and builds `self.steps` inline (old build_compute body). - DatapipeApp.run()/run_changelist() contain the real execution loops (old run_steps/run_steps_changelist bodies), defaulting to self.ds/self.steps. - Pipeline, and the five free functions, are removed from datapipe.compute. - datapipe-app's make_app() now takes the DatapipeApp instance instead of unpacked ds/catalog/pipeline/steps, avoiding a rebuild per request. - Updated every call site across datapipe-core, datapipe-cvat, datapipe-label-studio, datapipe-ml, datapipe-app, and examples/*. See design-docs/2026-08-consolidated-app.md for the full design writeup. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
elephantum
force-pushed
the
push-ouxoppqslwyr
branch
from
September 14, 2026 05:46
f23d140 to
b602682
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipelinewas a one-field wrapper aroundSequence[PipelineStep]with no behavior;build_compute/run_steps/run_steps_changelist/run_pipeline/run_changelistwere free functions in datapipe.compute that every real caller (CLI, datapipe-app, examples) reached by manually unpacking an already-in-scope DatapipeApp instance.pipeline: Sequence[PipelineStep]directly and buildsself.stepsinline (old build_compute body).See design-docs/2026-08-consolidated-app.md for the full design writeup.