Declare the context input again; serving does not read it - #13
Merged
Merged
Conversation
The feed API sends a "context" input whenever a SERP carries a country/region/type filter (serp_subfeeds builds it best-effort and the client attaches it when non-empty). Triton rejects any request that names an input the model config does not declare, so dropping the input with the orchestrator on 2026-08-14 turned every filtered feed request into SmartRecUnavailableError once a trainer built from that tree synced the config. Declare it as optional again and leave model.py alone: no served model consumes it. Remove it only after the API stops sending it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-declares the optional
contextinput inserving/config.pbtxt.model.pyis untouched and still does not read it.Why
The feed API sends
contextwhenever a SERP carries a country/region/type filter (serp_subfeedsbuilds it best-effort, the client attaches it when non-empty). Triton rejects a request that names an input the model config does not declare. Dropping the input together with the orchestrator on 2026-08-14 therefore turns every filtered feed request intoSmartRecUnavailableErroras soon as a trainer built from that tree syncs the config into S3. The prod trainer (2026.08.13) still ships the old config, so prod has not hit this yet; dev has since 2026-08-25.Change type (CLAUDE.md §5.11)
Config/serving-file change: needs a trainer image rebuild and a retrain so the trainer syncs the new
config.pbtxt. No runtime repack needed, the library code is unchanged.Remove the input only after the API stops sending it.