feat(git): support non-origin remotes#19
Merged
Conversation
…olution - createWorktreeFromRemote resolves the remote internally (param now optional), so 'wt create <remote-branch>' works on non-origin remotes instead of failing against a hardcoded origin/<branch> - prefer main/master tracking remote over HEAD's when resolving the primary remote: HEAD may track a side remote (fork), the wrong answer for the repo-level queries these methods perform - treat git's '.' tracking sentinel (local-branch tracking) as 'no remote' so resolution falls through instead of poisoning the cache - rename resolved -> remoteName, dedupe the refs/remotes/<remote>/ prefix - test: create-from-remote via a resolved non-origin remote
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"origin/..."frombun-git-adapter.ts(listRemoteBranches,getDefaultBranch,mergeFFOnly,updateBranchRef, anddeleteRemoteBranch)branch.<HEAD>.remote->branch.main.remote->branch.master.remote-> sole-remote auto-detect ->"origin"--upstreamis not literallyorigincreateRemoteFixturegains an optionalremoteNameto drive the new tests (existing callers unaffected)Closes Vikunja #36.
Test plan
pnpm typecheckpassespnpm lintpassespnpm testpasses (472 tests, 7 new)upstream), multi-remote disambiguation viabranch.main.remote, no-remote-configured errororigin-based tests unchanged