fix: don't specify gift for a generic transaction type#201
Open
iloveitaly wants to merge 2 commits into
Open
Conversation
Owner
|
Welcome back! The documentation check is due to a dead link. I disabled the check for it: could you rebase your PRs and upload the code again? |
eprbell
reviewed
Sep 17, 2023
Owner
eprbell
left a comment
eprbell
left a comment
There was a problem hiding this comment.
I'm not sure I see the point of this change: Gift is an arbitrary choice, but sell is also an arbitrary choice. The user can control the final type using transaction hints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.