feat: Create coinbase-advanced rest plugin#293
Conversation
…nger functional, as Coinbase Pro no longer exists and the old rest api requires different authentication.
…egged value for now for handling cases where Coinbase hasn't provided us with more specific values when calculating spot prices.
… coinbase_advanced rest plugin. This is to simplify setup and provide some additional security to users.
…base_advanced rest api
|
What else is needed to get this merged in? I see Documentation Check errors with broken links, but those links don't appear to be related to changes in this PR. I believe I've fixed all errors reported by pylint. Some warnings and convention level messages remain and I could resolve a few of those, but a few I disagree with, too. Does this project treat pylint warnings as a cause for static analysis failure, or are there errors that I didn't see in the log? |
…ipping broken link detection on Binance URLs, as they are blocked by certain jurisdictions.
…nger functional, as Coinbase Pro no longer exists and the old rest api requires different authentication.
…egged value for now for handling cases where Coinbase hasn't provided us with more specific values when calculating spot prices.
… coinbase_advanced rest plugin. This is to simplify setup and provide some additional security to users.
…base_advanced rest api
…ipping broken link detection on Binance URLs, as they are blocked by certain jurisdictions.
c709921 to
71074d4
Compare
|
Were there changes to abstract_input_plugin.py that are not included? This doesn't work for me. |
|
@anlach Thank you for reporting this. I'm not sure how this was working before, but I reproduced that issue. It seems to be some stray code that I copied from the original Coinbase plugin and isn't needed for the coinbase-advanced plugin, so I removed it (along with another typo). The changes are now in this PR. |
Adding a new coinbase_advanced rest plugin. The old plugins are no longer functional, as Coinbase Pro no longer exists and the old rest api requires different authentication.
This also includes a change to the "coinbase_advanced" spot price retrieval plugin, as it was failing due to Coinbase's introduction of USDC without providing a USDC/USD product-id/lookup.
A Dockerfile is included in case security-conscious users want to run in a sandbox and also because the new rest plugin requires the Coinbase Rest Client, which this Dockerfile auto-installs.