Skip to content

Fixes #506 by removing empty failed add records #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drn05r wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #506 by removing empty failed add records #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion perl_lib/EPrints/Apache/CRUD.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,7 +1008,7 @@ sub parse_input
}
elsif( $count == 0 || ( $list->count == 0 && $self->{method} ne "PUT" && $self->{method} ne "PATCH" ) )
{
$plugin->handler->message( "error", "Import plugin didn't create anything" );
$plugin->handler->message( "error", "Import plugin didn't create anything. Check ".$repo->config( 'perl_url' )."/schema to ensure the metadata being sent is valid." );
$self->plugin_error( $plugin, \@messages );
return undef;
}
Expand Down
10 changes: 9 additions & 1 deletion perl_lib/EPrints/Database.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1911,7 +1911,15 @@ sub add_record
}

# Now add the ACTUAL data:
return $self->update( $dataset, $data, $data );
my $rc = $self->update( $dataset, $data, $data );

# If the update failed then delete the empty record created by the earlier insert
if ( !$rc )
{
$self->remove( $dataset, $id );
}

return $rc;
}


Expand Down