Allow meck:wait/{4,5,6} to be called with a condition#257
Open
rlipscombe wants to merge 8 commits intoeproxus:masterfrom
Open
Allow meck:wait/{4,5,6} to be called with a condition#257rlipscombe wants to merge 8 commits intoeproxus:masterfrom
rlipscombe wants to merge 8 commits intoeproxus:masterfrom
Conversation
When testing some non-deterministic code, I needed something that would wait for a function to be called with [1, 2, 3], but not necessarily all at once, and not necessarily in that order. That is: m:f([1]), m:f([2]), m:f([3]) is just as valid as m:f([1, 2]), m:f([3]), and as valid as m:f([2]), m:f([3, 1]), and so on. So: invent a way for meck to update what it's waiting for as the history is built. By accumulating state as the calls happen, we can check that the function is called with the correct arguments, whatever the order. This is called a 'condition'. Doc comment updates to follow in a later commit.
rlipscombe
force-pushed
the
wait-condition
branch
from
a5175e8 to
6487e91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing some non-deterministic code, I needed something that would
wait for a function to be called with [1, 2, 3], but not necessarily
all at once, and not necessarily in that order.
That is: m:f([1]), m:f([2]), m:f([3]) is just as valid as m:f([1, 2]),
m:f([3]), and as valid as m:f([2]), m:f([3, 1]), and so on.
So: invent a way for meck to update what it's waiting for as the
history is built. By accumulating state as the calls happen, we can
check that the function is called with the correct arguments, whatever
the order.
This is called a 'condition'.
This is a re-written version of PR #253, with that feedback addressed (hopefully).