Skip to content

fix: support pdf#803

Open
jiyeol-lee wants to merge 2 commits into
epwalsh:mainfrom
jiyeol-lee:fix/add-pdf-callback
Open

fix: support pdf#803
jiyeol-lee wants to merge 2 commits into
epwalsh:mainfrom
jiyeol-lee:fix/add-pdf-callback

Conversation

@jiyeol-lee
Copy link
Copy Markdown

now only url and pdf file types are supported to open but i think pdf file is pretty much common.

Comment thread lua/obsidian/client.lua
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log.warn should read:
"This looks like a pdf path. You can customize the behavior of pdfs with the 'follow_pdf_func' option."

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants