Further optimize handling of torrents with large number of files#710
Merged
Further optimize handling of torrents with large number of files#710
Conversation
Owner
equeim
commented
Apr 8, 2026
- Don't recursively calculate properties of a directory every time they are accessed, do it only the first time and store them, and update them when they change
- Don't use polymorphism for TorrentFilesModelEntry. Instead store file or directory data in it directory using std::variant. This allows storing entries in contiguous vectors in directories instead of allocating each one separately and storing pointers.
- Don't split file paths into std::vector each time they are parsed from JSON, do it only once when building file tree.
…rentFilesModelDirectory to TorrentFilesTreeBuilder so that it can be disposed of after building the tree
…and remove changed flag from TorrentFilesModelFile
…nstead of using polymorphism, and remove synthetic root directory in BaseTorrentFilesModel
2577b03 to
72516cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.