feat(executor): deprecate our hardcoded Starknet version constants - use blockifier bundled ones instead#3486
Draft
t00ts wants to merge 2 commits into
Draft
feat(executor): deprecate our hardcoded Starknet version constants - use blockifier bundled ones instead#3486t00ts wants to merge 2 commits into
t00ts wants to merge 2 commits into
Conversation
t00ts
force-pushed
the
t00ts/executor-versions
branch
from
f041e7d to
431d557
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hardcoded list caused trouble today and can bite us again in the future. We essentially have to remember to add new versions as they're supported, which is error prone and clumsy.
Blockifier bundles this list, so this PR uses those directly instead.
No more hardcoded lists. No more oversights.