feat(zair-sdk): support all gaptree modes in the integration api#54
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
zeapoz
force-pushed
the
feat/api-gaptree-modes
branch
from
57851f9 to
260e15f
Compare
mikdk
approved these changes
Apr 21, 2026
| match self { | ||
| Self::Sapling(tree) => tree.root_bytes(), | ||
| Self::Orchard(tree) => tree.root_bytes(), | ||
| Self::SaplingSparse(tree) => tree.root().to_bytes(), |
Collaborator
There was a problem hiding this comment.
we cannot use root_bytes() here?
Collaborator
Author
There was a problem hiding this comment.
Yeah, for some reason NonMembershipTree doesn't define it whilst the others do. Likewise, we can't do NonMembershipTree::witness_bytes either. Implemented them in latest commit
| viewing_keys: &ViewingKeys, | ||
| airdrop_config: &AirdropConfiguration, | ||
| snapshot_nullifiers: Option<SanitiseNullifiers>, | ||
| snapshot_nullifiers: Option<zair_core::base::SanitiseNullifiers>, |
mikdk
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_pool_merkle_treeto use the integration API gaptree implementation