Skip to content

fix(bumpconfig): Consider refactor!: change to be a breaking change#83

Merged
JimFawkes merged 1 commit intomainfrom
feat/update-major-version-bump-pattern
Feb 17, 2026
Merged

fix(bumpconfig): Consider refactor!: change to be a breaking change#83
JimFawkes merged 1 commit intomainfrom
feat/update-major-version-bump-pattern

Conversation

@JimFawkes
Copy link
Collaborator

This Change adresses #82

@JimFawkes JimFawkes requested a review from erNail February 16, 2026 14:14
@JimFawkes
Copy link
Collaborator Author

Is this a breaking change? I am not really sure.

@JimFawkes JimFawkes self-assigned this Feb 16, 2026
@JimFawkes JimFawkes added bug Something isn't working invalid This doesn't seem right labels Feb 16, 2026
@JimFawkes JimFawkes force-pushed the feat/update-major-version-bump-pattern branch 2 times, most recently from b072562 to 2e12cfe Compare February 16, 2026 16:34
@erNail
Copy link
Owner

erNail commented Feb 17, 2026

Looking very good, i only found a tiny typo.

Regarding if this could be considered a breaking change: I don't really see any users adding a ! to the commit and not expecting a major version bump. But it's also a change that could cause issues if users are currently using ! without a BREAKING CHANGE: commit message body. Let's be on the safe side and make it a breaking change.

For the changelog, i think a commit like this would be useful (improvements welcome):

feat(bumpconfig)!: Adapt default configuration to detect a major bump if an exclamation mark is used in the commit message, no matter what the commit message body is

BREAKING CHANGE: Before, `verscout` would detect a major version bump only if `BREAKING CHANGE:` was used in the commit message body. To align with the newest [Conventional Commit Specification](https://www.conventionalcommits.org/en/v1.0.0/), using a `!` right before the `:`, eg `refactor!: Rename API method`, will now be enough to cause a major version bump.

@JimFawkes JimFawkes force-pushed the feat/update-major-version-bump-pattern branch from 2e12cfe to e69831d Compare February 17, 2026 12:52
… if an exclamation mark is used in the commit message, no matter what the commit message body is

BREAKING CHANGE: Before, `verscout` would detect a major version bump
only if `BREAKING CHANGE:` was used in the commit message body.
To align with the newest [Conventional Commit Specification](https://www.conventionalcommits.org/en/v1.0.0/),
using a `!` right before the `:`, eg `refactor!: Rename API method`, will now be enough to cause a major version bump.
@JimFawkes JimFawkes force-pushed the feat/update-major-version-bump-pattern branch from e69831d to 2c40726 Compare February 17, 2026 12:52
Copy link
Owner

@erNail erNail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JimFawkes JimFawkes merged commit 2611d12 into main Feb 17, 2026
5 checks passed
@JimFawkes JimFawkes deleted the feat/update-major-version-bump-pattern branch February 17, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants