Feat/migrate to dart 3.7 analyzer 9#3
Open
abdalraheemKshinba wants to merge 4 commits into
Open
Conversation
mohn93
approved these changes
Jan 1, 2026
| type_plus: | ||
| git: | ||
| url: https://github.com/erabti/jserializer_library.git | ||
| url: https://github.com/abdalraheemKshinba/jserializer_library.git |
Collaborator
There was a problem hiding this comment.
i think it's better to reference the main repo in here
| final ModelConfig modelConfig; | ||
|
|
||
| String get className => classElement.name; | ||
| String get className => classElement.name ?? ''; |
Collaborator
There was a problem hiding this comment.
Not sure if this affects the behavoir of what is depending on this, @erabti i guess this needs your review
| name: jserializer_generator | ||
| description: A starting point for Dart libraries or applications. | ||
| version: 1.1.1 | ||
| description: Code generator for jserializer - serialization done right. |
| path: jserializer/ | ||
| merging_builder: | ||
| git: | ||
| url: https://github.com/abdalraheemKshinba/jserializer_library.git |
Collaborator
There was a problem hiding this comment.
be careful of referencing different repos in the same repo
| build_runner: ">=2.4.4<3.0.0" | ||
| dart_style: ^3.0.1 | ||
| analyzer: ">=8.0.0 <10.0.0" | ||
| build: ">=3.0.0 <5.0.0" |
- Update all packages to SDK >=3.7.0 <4.0.0 - Migrate to analyzer >=8.0.0 <10.0.0 - Update source_gen to >=4.0.0 <5.0.0 - Update build to >=3.0.0 <5.0.0 - Fix all breaking API changes: - TypeChecker.fromRuntime -> TypeChecker.fromUrl - Element.name returns String? (add null assertions) - parameters -> formalParameters - enclosingElement3 -> enclosingElement - getDisplayString(withNullability:) -> getDisplayString() - PropertyAccessorElement -> GetterElement - ParameterElement -> FormalParameterElement - library.definingCompilationUnit -> library.firstFragment - param.metadata -> param.metadata.annotations - Add caching optimizations to generator and type resolver - Remove tracked IDE and system files, add .gitignore - Internal git refs point to erabti:main Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
abdalraheemKshinba
force-pushed
the
feat/migrate-to-dart-3.7-analyzer-9
branch
from
a93a3b4 to
56591cc
Compare
Internal jserializer and merging_builder git refs now point to the fork's migration branch instead of erabti:main, since the migration changes haven't been merged upstream yet. Once PRs erabti#3 and erabti#5 are merged into erabti/jserializer_library main, these refs should be updated back to erabti:main.
The generator code references safeLookup for safe field lookup configuration, but the annotation class was missing this parameter.
The caching optimization from the perf PR could miss annotated classes from libraries loaded after stabilization. Revert to always loading the full library list for each annotated file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.