fix: a issue with hash conflicts and fixes erdelf/MinifyEverything#17#20
Open
thakyZ wants to merge 1 commit intoerdelf:masterfrom
Open
fix: a issue with hash conflicts and fixes erdelf/MinifyEverything#17#20thakyZ wants to merge 1 commit intoerdelf:masterfrom
thakyZ wants to merge 1 commit intoerdelf:masterfrom
Conversation
Owner
|
finally? I'm surprised someone played with the github release. I don't.. like this approach.. or the mess that is CodeMatcher.. but I'll consider it, keeping the PR open for now. |
Author
|
Typically, we would use Also, I used the GitHub release, because the Steam version does not have a source provided. On top of the GitHub version not breaking some categories for the filter menus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you, @kittycat2002
He helped me to fix this issue, finally found out it is a hash conflict. Hopefully this fix can be permanent.
And as said in the title, fixes: #17