ci(e2e): Playwright runs against the mocked stack on every PR (soak phase)#177
Merged
Conversation
…hase) The e2e-mock job was curl-only; the real browser suite sat behind an e2e:run label nobody applies. Now the SAME job — one boot, one build — runs the Playwright suite after its curl smoke, on every PR: - WORLD_MODE=true on the boot (backend flag + the compose build-arg fallthrough bakes NEXT_PUBLIC_WORLD_MODE into the web bundle) so the world/interior specs can exist; classic paths stay exercisable. - pnpm + node + ms-playwright caches; browsers installed per run (~30-40s warm); report + test-results uploaded always; compose logs dumped on failure. - continue-on-error=true is the SOAK: the suite must prove itself green across ~10 unrelated PRs before the one-line flip PR makes browser tests REQUIRED. The curl gate never loosens meanwhile. - playwright.config: E2E_MOCK tightens timeouts (120s/30s vs 240s/60s) so a hang fails in minutes; the label-gated real-key e2e job is untouched.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the required
e2e-mockjob (one boot, one build) to run the real Playwright suite after its curl smoke, on every PR:WORLD_MODE=trueon the boot — backend flag + the compose build-arg fallthrough bakesNEXT_PUBLIC_WORLD_MODEinto the web bundle, so the upcoming world/interior specs are testable; classic paths stay exercisable (per-requestworld_mode:false+ the UI toggle).always; compose logs dumped on failure.continue-on-error: true= the soak: the suite proves itself across ~10 unrelated PRs, then a one-line flip PR makes browser tests required. The curl gate never loosens meanwhile.E2E_MOCKtightens Playwright timeouts (120s/30s) so hangs fail fast; the label-gated real-keye2ejob is untouched.The 4 existing specs run under mock from this PR — the first soak signal. Job runtime ~10–13 min (was ~3–5); the PR lane's long pole is unchanged.
🤖 Generated with Claude Code