[ERP-4736] Fix patient edit page crash for self-registered patients#117
Merged
ppettitau merged 1 commit intoMay 21, 2026
Merged
Conversation
has_assigned_carer() was passing an unsaved PrimaryCarer instance (no PK) to a related ORM filter for patients with no PrimaryCarerRelationship (e.g. self-registered patients). This silently no-op'd in Django 4.x but raises a hard ValueError in Django 5.0+. Add an instance.pk guard so unsaved instances short-circuit to False. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Django 5.0+ crash on the patient edit page for self-registered patients by preventing an ORM filter from receiving an unsaved PrimaryCarer instance (no primary key).
Changes:
- Add an
instance.pkguard inPrimaryCarerForm.has_assigned_carer()so unsaved instances short-circuit toFalse. - Avoid triggering
ValueErrorfrom Django’s ORM when filtering by an unsaved related model instance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
has_assigned_carer() was passing an unsaved PrimaryCarer instance (no PK) to a related ORM filter for patients with no PrimaryCarerRelationship (e.g. self-registered patients). This silently no-op'd in Django 4.x but raises a hard ValueError in Django 5.0+.
Add an instance.pk guard so unsaved instances short-circuit to False.